Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate sqs source #2403

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: integrate sqs source #2403

wants to merge 4 commits into from

Conversation

cosmic-chichu
Copy link
Contributor

Integrate sqs source with controller.

Fixes #2390 and #2368

  • add support for all sqs configs
  • support different ways to authenticate

Note: pending use Initialism

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 66.25917% with 138 lines in your changes missing coverage. Please review.

Project coverage is 70.60%. Comparing base (b918846) to head (5b08fe4).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
rust/extns/numaflow-sqs/src/source.rs 69.83% 54 Missing ⚠️
rust/numaflow-core/src/config/components.rs 0.00% 47 Missing ⚠️
rust/numaflow-core/src/shared/create_components.rs 0.00% 19 Missing ⚠️
rust/extns/numaflow-sqs/src/client.rs 89.79% 15 Missing ⚠️
rust/numaflow-core/src/source/sqs.rs 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2403      +/-   ##
==========================================
- Coverage   71.03%   70.60%   -0.44%     
==========================================
  Files         367      368       +1     
  Lines       53042    54421    +1379     
==========================================
+ Hits        37678    38423     +745     
- Misses      14289    14920     +631     
- Partials     1075     1078       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosmic-chichu cosmic-chichu marked this pull request as draft February 20, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQS Missing Features
1 participant