Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shellcheck --severity=warning on all shell scripts #1371

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

johnbley
Copy link

When using nuke in a project and applying shellcheck --severity=warning (a wonderful shell linting tool), it turned up a minor nit in nuke's build.sh. So, it was suggested by a colleague that I fix this "at the source" 馃槃 .

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@matkoch
Copy link
Member

matkoch commented Apr 16, 2024

Could you give some information on what the actual warning is?

@johnbley
Copy link
Author

johnbley commented Apr 16, 2024

Could you give some information on what the actual warning is?

Oh! Sure thing! Basically we don't want to ignore the return value of command -v dotnet:

SC2155 (warning): Declare and assign separately to avoid masking return values.

https://www.shellcheck.net/wiki/SC2155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants