Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOFAR reader hotfixes #679

Merged
merged 13 commits into from
May 24, 2024
Merged

LOFAR reader hotfixes #679

merged 13 commits into from
May 24, 2024

Conversation

MijnheerD
Copy link
Collaborator

This PR contains a bunch of small hotfixes for the LOFAR branch:

  • The TBB reader now raises an IndexError when the endpoint is off the end of a file
  • TBB files from remote stations are now skipped when globbing over the directory (solves crashes involving events with only remote TBB files)
  • The channel group IDs are now int instead of str (for consistency with Detector description)
  • After reading in the channels, we now check whether both channels from the flagged group IDs are removed from the station
  • The calibration delays can now be retrieved from the readLOFARData object as a dict, ensuring the calibration delays are associated to the correct channel ID

@MijnheerD MijnheerD changed the title Lofar/hotfixes LOFAR reader hotfixes May 16, 2024
Copy link
Collaborator

@anelles anelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good from my side, but I haven't tested this.
I assume you tested that it works.
Feel free to wait for LOFAR core team to review in independent cross-check, but you the ok to merge already.

@karenterveer karenterveer merged commit 9f50e98 into lofar/development May 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants