Focusing factor #649
Open
Focusing factor #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce-to-air raytracing
…or refracted rays where analytic solution is not valid
|
The unit tests found a bug in my implementation for trajectories including bottom reflections. This should now be fixed, i.e. only the reference files and the changelog still need to be updated. This pull request can already be reviewed, and I would be happy to receive feedback. |
|
You should get Dave Seckel to review this, but I am not sure that he does code review :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a missing factor in the focusing factor used in NuRadioMC. This PR also fixed a couple of incorrect analytic formulas for the path length and travel time in the analytic ray-tracing case, and fixes the double-counting of the focusing factor for ice-to-air (or air-to-ice) ray-tracing. For more details, see #648