Merged develope into simulation_refactor #615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponseIncorporator. Keep implementation for the generic detector class for now.
…Add hack which drops the drab board reponse from the signal chain when it has the same reponse as the iglu
…nction get_antenna_model. Add hard-coded value for cable delay
Bugfix
…nents to avoid ambiguity
…...) into get_position(...) and get_{station,channel,device}_identifier(..) into get_identifier(...)
Moved bugfix comment under 2.2.0-dev
Copy kwargs dicts before manipulating them
…ted variable _bandwidth_per_channel
…y to adjust the primary time start date when adding measurements to the database
revert variable change to assure backward compatibility with Gen2 TDR…
whitespace only
Automatically make tag and github release on pushes to master
Refactoring electric_field.py
Implementing a RNO-G detector class using a mongo-db interface
|
@christophwelling this is my attempt to merge the develop branch into this one and keeping the latest changes from simulation.py. The diff is of course very large but I guess you could restrict yourself to the files you touched in the original branch |
|
I guess I will close this PR since the target branch is not getting merged as it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.