Feature/arbitrary noise spectra #585
Conversation
|
I think this is useful for standalone applications. However, it should still be able to define the desired Vrms. We do that all the time. One just needs to calculate the normalization, which is the integral over the square of the filter function within the fmin, fmax interval. |
There was a problem hiding this comment.
I agree with Christan, that it would be nice to have the custom filter as an additional parameter that can both be an array of amplitudes or a function that returns the amplitudes. Then maybe the amplitude can be taken into account.
Otherwise I only have two minor comments.
| if callable(amplitude): | ||
| sigscale = sampling_rate | ||
| else: | ||
| sigscale = (1. * n_samples) / np.sqrt(nbinsactive) |
There was a problem hiding this comment.
These four lines can maybe be included in the if statements above (line 137 to 144) as this is just another scaling. It should maybe also be applied there.
| type: string | ||
| perfect_white: flat frequency spectrum | ||
| rayleigh: Amplitude of each frequency bin is drawn from a Rayleigh distribution |
There was a problem hiding this comment.
Maybe type should be renamed to fluctuation_type and perfect_white to just perfect.
New feature - rather than simulating only flat noise spectra with the channelGenericNoiseAdder, I added the option to specify the desired frequency spectrum as a function of frequency. Note that this (somewhat by design) is not compatible with specifying a desired Vrms.
Just sharing in case someone else thinks this might be useful - happy to refine the implementation if desired.