Fix test_adl for azure-datalake-store 1.0.1+ compatibility#866
Merged
rgbkrk merged 1 commit intonteract:mainfrom Mar 7, 2026
Merged
Fix test_adl for azure-datalake-store 1.0.1+ compatibility#866rgbkrk merged 1 commit intonteract:mainfrom
rgbkrk merged 1 commit intonteract:mainfrom
Conversation
The azure-datalake-store library removed the 'auth' attribute from the lib module in version 1.0.1. Add create=True to patch.object to allow mocking the attribute even when it doesn't exist in the module.
rgbkrk
approved these changes
Mar 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
==========================================
- Coverage 91.54% 91.13% -0.42%
==========================================
Files 17 17
Lines 1621 1635 +14
==========================================
+ Hits 1484 1490 +6
- Misses 137 145 +8 see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #825
What does this PR do?
This PR fixes the
test_create_adaptertest intest_adl.pyto be compatible with azure-datalake-store 1.0.1+.The azure-datalake-store library removed the
authattribute from thelibmodule in version 1.0.1 (see upstream PR #333). This caused the test to fail with:The fix adds
create=Trueto thepatch.objectdecorator, which allows mocking theauthattribute even when it doesn't exist in the module.Changes
papermill/tests/test_adl.py: Addedcreate=Trueparameter to@patch.object(adl_lib, 'auth', ...)decoratorTesting
Verified the fix works with azure-datalake-store 1.0.1:
Diff stats