PENG-6243 - Introduce support for billing-usage APIs #134
Conversation
| @@ -11,7 +11,7 @@ jobs: | |||
| uses: actions/checkout@v2 | |||
There was a problem hiding this comment.
The v1 version doesn't support python 3.8 anymore it seems. Updating it to v4 solves the issue
There was a problem hiding this comment.
I feel like all of our GitHub actions should be tracked with Dependabot. Probably our other dependencies too, since they all seem to be development or build related?
| @@ -32,12 +32,12 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
There was a problem hiding this comment.
Please see this versions, these are the ones we're actually testing against. Because of this, I'm updating the readme
There was a problem hiding this comment.
Python 3.8 was EOL almost 6 months ago:
https://devguide.python.org/versions/
I guess it's okay to continue to support it, although not too strenuously. 😉
There was a problem hiding this comment.
Yeah, thought about just doing 3.9 onwards. Let me know if you want me to do it or if we're happy to support 3.8 for now
There was a problem hiding this comment.
I think it's fine, although if any of our CI tools stop working then we should happily drop 3.8 support!
| @@ -15,8 +15,8 @@ and includes both a simple NS1 REST API wrapper as well as a higher level | |||
| interface for managing zones, records, data feeds, and more. | |||
There was a problem hiding this comment.
Updating based on my comment above
| @@ -45,6 +44,10 @@ class Config: | |||
|
|
|||
| API_VERSION = "v1" | |||
There was a problem hiding this comment.
First time we're adding support for endpoint under the new schema, so I had to come up with a solution
https://api.nsone.net/v1/zones vs https://api.nsone.net/zones/v1
| @@ -247,9 +247,9 @@ def _request_func(self, method, headers, data, files): | |||
|
|
|||
There was a problem hiding this comment.
Formatting highlighted by the linter
| @@ -11,7 +11,7 @@ jobs: | |||
| uses: actions/checkout@v2 | |||
There was a problem hiding this comment.
I feel like all of our GitHub actions should be tracked with Dependabot. Probably our other dependencies too, since they all seem to be development or build related?
| @@ -32,12 +32,12 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
There was a problem hiding this comment.
Python 3.8 was EOL almost 6 months ago:
https://devguide.python.org/versions/
I guess it's okay to continue to support it, although not too strenuously. 😉
/billing-usage/v1/queries/billing-usage/v1/decisions/billing-usage/v1/monitors/billing-usage/v1/records/billing-usage/v1/filter-chains/billing-usage/v1/limits