fix(js): check package.json for name when project.json exists but has no name #31887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=lint,test,build,e2e,e2e-c... |
❌ Failed | 46m 20s | View ↗ |
nx run-many -t check-imports check-commit check... |
✅ Succeeded | 15s | View ↗ |
nx-cloud record -- nx-cloud conformance:check |
✅ Succeeded | 2s | View ↗ |
nx-cloud record -- nx format:check |
✅ Succeeded | 3s | View ↗ |
nx-cloud record -- nx sync:check |
✅ Succeeded | 2s | View ↗ |
nx documentation |
✅ Succeeded | 2m 3s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-07-12 04:05:23 UTC
leosvelperez
approved these changes
Jul 10, 2025
|
@claude fix the formatting in this PR |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
@claude please format these changes. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
… no name When a project.json exists but has no name field, now falls back to checking package.json for project name in build and watch deps targets. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
FrozenPandaz
force-pushed
the
fix/js-project-name-fallback
branch
from
3e4447b to
8340f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When a project has a
project.jsonfile but nonamefield, theaddBuildAndWatchDepsTargetsfunction inpackages/js/src/plugins/typescript/util.tsreturns early without creating build and watch deps targets, even if the project has a valid name in itspackage.json.Expected Behavior
The function should fall back to checking
package.jsonfor the project name whenproject.jsonexists but has nonamefield, allowing the build and watch deps targets to be created properly.Related Issue(s)
This fixes an issue where projects with
project.jsonfiles missing thenamefield would not get proper build and watch dependency targets generated.🤖 Generated with Claude Code