-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(e2e): streamline CI workflow and add debugging output #31830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
FrozenPandaz
wants to merge
45
commits into
master
Choose a base branch
from
test-e2e
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update types and ensure with generating with SSG brower apis are not used. - Add all paths to root tsconfig.json
- packages and nx-dev are using inferred plugins tsc/next - updated project.json files for multiple packages to streamline build dependencies and tasks. - introduced a new executor for copying assets, enhancing the build process. - modified scripts for copying README and assets to use the new executor. - Adjusted TypeScript configuration to support new executor and asset management. - Removed unnecessary references and cleaned up code for better maintainability.
- Marked all packages in the graph and nx-dev directories as private in their respective package.json files. - Updated webpack output paths from 'build' to 'dist' in the graph/client webpack configuration. - Adjusted various project.json files to change output paths from 'build/packages' to 'dist/packages' for consistency. - Modified scripts to reference the new 'dist' directory for package.json and storage paths.
- Updated the custom Jest resolver to support TypeScript source resolution for specific Nx workspace packages. - Added module name mappings in Jest configurations for tools and workspace plugins to point to the correct package paths.
…kage.json resolution - Remove old jasmine types that were clashing with jest types
…ion workspace. - Next.js fix event listener callback for router.on events
…ency across multiple packages - update ESLint configuration files to extend from .eslintrc.json and ignore node_modules refactor: update generator factory paths in generators.json files for consistency docs: enhance descriptions in schema.json files for better clarity on asset copying chore: add node_modules to ignore patterns in various ESLint configurations for ts solution this is necessary as the base eslint ignores is not applied.
- Adjust angular copying assets
…management - Introduced a new executor `add-package-json-fields` to add required fields like `types` and `type` to package.json files of built packages. - Updated project.json files across multiple packages to include the new executor in their build processes. - Modified the `copy-assets` executor to ensure it runs before the new executor. - Enhanced the `nx-release-publish` target to depend on the new executor for better package management. - Updated package.json files to ensure correct typings and type fields are set for various packages.
…with legacy-post-build executor - Removed the copy-assets executor - Removed add-package-json-fields executor - Add legacy-post-build executor that combines asset copying and package.json field updates.
…tead of overwriting.
…rybook, vite, webpack, and vue packages - remove jest from devDependencies for packages - update legacy post-build executor to accept custom main and types fields in package.json - Update nx-dev deploy production task to copy artifacts to dist/nx-dev/nx-dev
- Fix app router index pages returning 404 by using revalidate instead of static generation - Fix blog post random ordering by using deterministic dates in blog API
- Removed unnecessary dependencies from various e2e project package.json files, retaining only "@nx/e2e-utils". - Updated import paths in test files to use "@nx/e2e-utils" instead of local utils. - Added TypeScript configuration file cleanup script to remove tsconfig and tsbuildinfo files from output directories. - Modified patched Jest resolver to skip workspace resolution for e2e tests, using the default resolver instead.
- update resolver for Jest workers and ensure test environment setup - update tools/embeddings pacakge to not be type module
…*/*.ts in tsconfig.spec.json
…workspace is different then we should not include it.
…that path as well when using ts solutions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The CI workflow runs extensive checks including documentation, format checks, sync checks, and conformance checks that may not be necessary for e2e testing focus.
Expected Behavior
Streamlined CI workflow that focuses on e2e testing for vite integration, with additional debugging output to help identify issues in child process execution.
Changes Made
This is a draft PR for testing and debugging purposes.