Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): only add keep existing versions if init generator supports it #30352

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Nx plugins which do not support keepExistingPackages fail to initialize via nx init or nx add

Expected Behavior

Nx plugins which do not support keepExistingPackages initializes properly via nx init and nx add

Related Issue(s)

Fixes #

Copy link

vercel bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2025 8:14pm

@FrozenPandaz FrozenPandaz marked this pull request as ready for review March 12, 2025 20:11
@FrozenPandaz FrozenPandaz requested a review from a team as a code owner March 12, 2025 20:11
@FrozenPandaz FrozenPandaz requested a review from xiongemi March 12, 2025 20:11
Copy link

nx-cloud bot commented Mar 12, 2025

View your CI Pipeline Execution ↗ for commit a5b740f.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ❌ Failed 48m 45s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=7f1e1... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 2m 55s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-12 23:58:02 UTC

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) March 12, 2025 20:27
@FrozenPandaz FrozenPandaz disabled auto-merge March 13, 2025 17:38
@FrozenPandaz FrozenPandaz merged commit cc9e993 into nrwl:master Mar 13, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants