Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): provide default value for max cache size #30351

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Mar 12, 2025

Current Behavior

The max cache size is disabled by default

Expected Behavior

Max cache size is set to 10% of the current disk by default, and can be disabled by specifying 0. Information about this shows up in nx report.

image

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested review from a team, FrozenPandaz and vsavkin as code owners March 12, 2025 20:01
Copy link

vercel bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2025 5:57pm

Copy link

nx-cloud bot commented Mar 12, 2025

View your CI Pipeline Execution ↗ for commit 19af373.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 1h 5m 52s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=cc9e9... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 1m 59s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-13 19:06:55 UTC

@AgentEnder AgentEnder force-pushed the feat/default-max-cache-size branch from 7080ef7 to 68d0044 Compare March 13, 2025 02:28
@FrozenPandaz FrozenPandaz force-pushed the feat/default-max-cache-size branch from 68d0044 to 19af373 Compare March 13, 2025 17:54
@FrozenPandaz FrozenPandaz enabled auto-merge (squash) March 13, 2025 17:54
@FrozenPandaz FrozenPandaz merged commit fe49308 into master Mar 13, 2025
12 checks passed
@FrozenPandaz FrozenPandaz deleted the feat/default-max-cache-size branch March 13, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants