Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use deprecated tag on workspace #30334

Open
wants to merge 1 commit into
base: 19.8.x
Choose a base branch
from

Conversation

cylewaitforit
Copy link

Current Behavior

Workspace says it is deprecated in the comment but does not use the @deprecated tag identifier.

Expected Behavior

Using the @deprecated tag allows tooling, like https://typescript-eslint.io/rules/no-deprecated/ , to easily identify code that will be removed. Many code editors will also strikethrough if it has been marked with the deprecated tag.

before after
Screenshot 2025-03-11 at 8 09 58 AM Screenshot 2025-03-11 at 8 08 44 AM

Related Issue(s)

Fixes #

@cylewaitforit cylewaitforit requested a review from a team as a code owner March 11, 2025 13:50
@cylewaitforit cylewaitforit requested a review from Cammisuli March 11, 2025 13:50
Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 1:54pm

Copy link

nx-cloud bot commented Mar 11, 2025

View your CI Pipeline Execution ↗ for commit 3c65664.

Command Status Duration Result
nx affected -t e2e-macos-local --parallel=1 --b... ✅ Succeeded 29m 7s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-11 14:33:10 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant