Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): allow for buildTargetWebpack to have an executor of @nx/webpack:webpack or @nx/rspack:rspack #30253

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(react): allow for buildTargetWebpack to have an executor of @nx/webpack:webpack or @nx/rspack:rspack #30253

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0d521f
fix(react): allow for buildTargetWebpack to have an executor of @nx/w…
Stovana Mar 3, 2025
b5797cf
Merge branch 'master' into 30235-allow-rspack-executor-for-webpack-cy…
Stovana Mar 4, 2025
ab3bbbf
Merge branch 'master' into 30235-allow-rspack-executor-for-webpack-cy…
Stovana Mar 4, 2025
2464aa3
Merge branch 'master' into 30235-allow-rspack-executor-for-webpack-cy…
Stovana Mar 5, 2025
aef265a
Merge branch 'master' into 30235-allow-rspack-executor-for-webpack-cy…
Stovana Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/react/plugins/component-testing/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,11 +237,13 @@ function buildTargetWebpack(

if (
buildableProjectConfig.targets[parsed.target].executor !==
'@nx/webpack:webpack'
'@nx/webpack:webpack' &&
buildableProjectConfig.targets[parsed.target].executor !==
'@nx/rspack:rspack'
) {
throw new InvalidExecutorError(
`The '${parsed.target}' target of the '${parsed.project}' project is not using the '@nx/webpack:webpack' executor. ` +
`Please make sure to use '@nx/webpack:webpack' executor in that target to use Cypress Component Testing.`
`The '${parsed.target}' target of the '${parsed.project}' project is not using the '@nx/webpack:webpack' or '@nx/rspack:rspack' executor. ` +
`Please make sure to use '@nx/webpack:webpack' or '@nx/rspack:rspack' executor in that target to use Cypress Component Testing.`
);
}

Expand Down