Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if dependencies & devDependencies exist before deleting dep #30224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: check if dependencies & devDependencies exist before deleting dep #30224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions packages/devkit/src/utils/package-json.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,15 +287,18 @@ export function removeDependenciesFromPackageJson(
)
) {
updateJson(tree, packageJsonPath, (json) => {
for (const dep of dependencies) {
delete json.dependencies[dep];
if (json.dependencies) {
for (const dep of dependencies) {
delete json.dependencies[dep];
}
json.dependencies = sortObjectByKeys(json.dependencies);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are improving this code if there are no dependencies we could also remove the dependencies instead of attempting to sort it.

}
for (const devDep of devDependencies) {
delete json.devDependencies[devDep];
if (json.devDependencies) {
for (const devDep of devDependencies) {
delete json.devDependencies[devDep];
}
json.devDependencies = sortObjectByKeys(json.devDependencies);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

}
json.dependencies = sortObjectByKeys(json.dependencies);
json.devDependencies = sortObjectByKeys(json.devDependencies);

return json;
});
}
Expand Down