Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add support for pnpm lockfile v9 #22906

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

feat(core): add support for pnpm lockfile v9 #22906

wants to merge 13 commits into from
+3,906 −539

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Apr 19, 2024 •
edited

  • Fix parenthesis separator detection
  • Fix leading dash detection
  • Migrate existing pnpm normalizer to latest code
  • Add unit tests for v9
  • Dogfooding Pnpm v9 to Nx repo and agents

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #22850

Potentially fixes #23256

@meeroslav meeroslav self-assigned this Apr 19, 2024
@meeroslav meeroslav requested a review from a team as a code owner April 19, 2024 12:10
@vercel Vercel
Copy link

vercel bot commented Apr 19, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 17, 2024 6:43pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 19, 2024 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ae7c330. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx affected --targets=lint,test,build --base=248949f9054c1cb2d458d677a3e1c71e4c2464a0 --head=ae7c330427801fd9bb50f156d2865e2a7d79d0d1 --parallel=3
✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@meeroslav meeroslav marked this pull request as draft April 19, 2024 12:23
@meeroslav meeroslav changed the title chore(repo): bump pnpm to v9 feat(core): add support for pnpm lockfile v9 Apr 19, 2024
@crbanman crbanman mentioned this pull request Apr 25, 2024
Open
4 tasks
@mattfysh
Copy link

great work @meeroslav ! would it also be useful to raise an error if the lockfileVersion encountered is outside the expected range?

binary64 added a commit to binary64/blabber that referenced this pull request May 6, 2024
@binary64
fix: use pnpm@8 until nrwl/nx#22906 is merged
78fee0a
@meeroslav meeroslav marked this pull request as ready for review May 17, 2024 08:20
@meeroslav meeroslav requested a review from a team as a code owner May 17, 2024 08:20
@mattfysh
Copy link

@meeroslav please don't blindly accept lockfiles whose versions are higher than 9, this is how the release of pnpm v9 caused all sorts of issues that didn't immediately map back to lockfile format support

please, if the lockfileVersion > 9 then throw an error to indicate that nx does not support that lockfile - this will save a lot of headaches in future

@meeroslav
Copy link
Contributor Author

Thank you @mattfysh, that's a good feedback.

@meeroslav meeroslav added the scope: core core nx functionality label May 17, 2024
@meeroslav meeroslav mentioned this pull request May 17, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgentEnder AgentEnder Awaiting requested review from AgentEnder AgentEnder is a code owner automatically assigned from nrwl/nx-pipelines-reviewers

@FrozenPandaz FrozenPandaz Awaiting requested review from FrozenPandaz

@vsavkin vsavkin Awaiting requested review from vsavkin

At least 1 approving review is required to merge this pull request.

Assignees

@meeroslav meeroslav

Labels
scope: core core nx functionality
Projects
None yet
Milestone
No milestone
3 participants
@meeroslav @mattfysh @JamesHenry