Skip to content

ci: disable e18e action duplicate dep PR comments#2593

Open
serhalp wants to merge 1 commit intomainfrom
serhalp/ci/disable-e18e-dup-dep
Open

ci: disable e18e action duplicate dep PR comments#2593
serhalp wants to merge 1 commit intomainfrom
serhalp/ci/disable-e18e-dup-dep

Conversation

@serhalp
Copy link
Copy Markdown
Member

@serhalp serhalp commented Apr 20, 2026

🔗 Linked issue

N/A

🧭 Context

We added this workflow recently, but it just posts (roughly) the same inactionable comment on PRs. It isn't really actionable information unless it calls out changes incurred by the PR itself.

📚 Description

Disable this functionality of the e18e dependency diff action.

@serhalp serhalp requested a review from 43081j April 20, 2026 01:21
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 20, 2026 1:22am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Apr 20, 2026 1:22am
npmx-lunaria Ignored Ignored Apr 20, 2026 1:22am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 20, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Adjusted internal workflow configuration to optimise dependency reporting noise levels.

Walkthrough

The e18e/action-dependency-diff workflow configuration was adjusted to increase the duplicate-threshold parameter from '4' to '999', effectively disabling duplicate-change reporting. A comment was added to document this adjustment. No other workflow behaviour was modified.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/dependency-diff.yml
Updated duplicate-threshold from '4' to '999' with an accompanying comment to suppress duplicate-change notifications.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: disabling duplicate dependency PR comments from the e18e action in the CI workflow.
Description check ✅ Passed The description is directly related to the changeset, providing context about the e18e workflow and explaining why duplicate-change reporting is being disabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch serhalp/ci/disable-e18e-dup-dep

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/dependency-diff.yml:
- Around line 38-39: The workflow uses an unsupported parameter
"duplicate-threshold" for the e18e/action-dependency-diff v1.5.0 action; inspect
the action's action.yml in that release (or the action docs) to confirm the
correct input name or behavior, then either remove "duplicate-threshold: '999'"
if no such input exists or replace it with the exact supported input key and
value (or implement a different mechanism to suppress noisy output), ensuring
the change targets the entry named "duplicate-threshold" in the workflow and
references the action e18e/action-dependency-diff@v1.5.0 when validating.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b52c592d-0c3a-4783-a6fa-e76c1d948cba

📥 Commits

Reviewing files that changed from the base of the PR and between d8aae4b and a729571.

📒 Files selected for processing (1)
  • .github/workflows/dependency-diff.yml

Comment on lines +38 to +39
# Too noisy. Disabling until this can report on duplicate CHANGES in this PR.
duplicate-threshold: '999'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check the e18e/action-dependency-diff documentation for duplicate-threshold parameter

# Fetch the action's README and action.yml to verify the parameter
rg -i 'duplicate-threshold' --type yaml --type md -C 5

Repository: npmx-dev/npmx.dev

Length of output: 43


🌐 Web query:

e18e/action-dependency-diff v1.5.0 duplicate-threshold parameter documentation

💡 Result:

No documentation found for a "duplicate-threshold" parameter in e18e/action-dependency-diff v1.5.0. The repository exists (https://github.com/e18e/action-dependency-diff), is public with 113 stars, and reports dependency changes in pull requests. However, searches across issues, README, action.yml, and releases did not reveal any mention of "duplicate-threshold". It may be an internal option, misremembered parameter name, or from a different version/tool. Check the action.yml file directly at https://github.com/e18e/action-dependency-diff/blob/v1.5.0/action.yml or contact the maintainer.

Citations:


The duplicate-threshold parameter does not appear to be supported by this action.

Web searches and action documentation do not show a duplicate-threshold parameter in e18e/action-dependency-diff v1.5.0. This setting may not be having any effect. Either verify the parameter name against the action.yml file directly, test whether the threshold actually works as intended, or consider removing this configuration if it is not functioning.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/dependency-diff.yml around lines 38 - 39, The workflow
uses an unsupported parameter "duplicate-threshold" for the
e18e/action-dependency-diff v1.5.0 action; inspect the action's action.yml in
that release (or the action docs) to confirm the correct input name or behavior,
then either remove "duplicate-threshold: '999'" if no such input exists or
replace it with the exact supported input key and value (or implement a
different mechanism to suppress noisy output), ensuring the change targets the
entry named "duplicate-threshold" in the workflow and references the action
e18e/action-dependency-diff@v1.5.0 when validating.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant