feat: add permissions support to trust commands#9248
Open
Conversation
Add --allow-publish and --allow-stage-publish flags to trust create operations. At least one permission flag is now required when establishing trust configurations. - Add PERMISSIONS constants for permission values - Add --allow-staged-publish as alias for --allow-stage-publish - Include permissions in request body and display output - Update tests and completion snapshots for new flags Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wraithgar
reviewed
Apr 16, 2026
wraithgar
reviewed
Apr 16, 2026
| module.exports = TrustCommand | ||
| module.exports.NPM_FRONTEND = NPM_FRONTEND | ||
| module.exports.trustDefinitions = trustDefinitions | ||
| module.exports.PERMISSIONS = PERMISSIONS |
Contributor
There was a problem hiding this comment.
Why are we exporting this?
karenjli
reviewed
Apr 16, 2026
| const allowStagePublish = flags['allow-stage-publish'] || flags['allow-staged-publish'] | ||
|
|
||
| if (!allowPublish && !allowStagePublish) { | ||
| throw new Error('Trust Relationships require permission access to run specific commands such as `npm stage` and `npm publish` please provide `--allow-stage-publish` or `--allow-publish` to proceed.') |
There was a problem hiding this comment.
The error message style doesn't match the short declarative pattern used elsewhere in this file
Suggested change
| throw new Error('Trust Relationships require permission access to run specific commands such as `npm stage` and `npm publish` please provide `--allow-stage-publish` or `--allow-publish` to proceed.') | |
| throw new Error(''At least one permission flag is required (--allow-publish, --allow-stage-publish)'') |
owlstronaut
reviewed
Apr 29, 2026
| const yes = this.config.get('yes') // deep-lore this allows for --no-yes | ||
|
|
||
| const allowPublish = flags['allow-publish'] | ||
| const allowStagePublish = flags['allow-stage-publish'] || flags['allow-staged-publish'] |
Contributor
There was a problem hiding this comment.
Suggested change
| const allowStagePublish = flags['allow-stage-publish'] || flags['allow-staged-publish'] | |
| const allowStagePublish = flags['allow-stage-publish'] |
I think the aliased key will have already been mapped to the main key by the time we get here
| static providerEntity = 'CircleCI pipeline' | ||
|
|
||
| static usage = [ | ||
| '[package] --org-id <uuid> --project-id <uuid> --pipeline-definition-id <uuid> --vcs-origin <origin> [--context-id <uuid>...] [-y|--yes]', |
Contributor
There was a problem hiding this comment.
Do we need to update the usage string for the new flags in each provider?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds permission flags to trust create operations. Users must now specify at least one of
--allow-publishor--allow-stage-publish(alias:--allow-staged-publish) when creating trust configurations.Changes
--allow-publishand--allow-stage-publishflags to all trust provider commands (GitHub, GitLab, CircleCI)PERMISSIONSconstants for permission valuesRelated