Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Crate with UI fixes #7536

Open
wants to merge 13 commits into
base: next
Choose a base branch
from
Open

Conversation

SokratisVidros
Copy link
Contributor

@SokratisVidros SokratisVidros commented Jan 17, 2025

What changed? Why was the change needed?

Pixel perfect implementation of the step editors

The fixes include:

  • Teach Codemirror to look and behave exactly like the rest of native HTML inputs regarding focus, rendering with errors, and overflowing with long content (text-wrapping).
  • Simplify the CSS logic of the variable pills and ensure they are not causing any jumps to the hosting editor.
  • Polish in-app action buttons.
  • Use simpler markup to render ControlInputs.
  • Apply copywriting fixes
  • Add client-side validation to the step creation form to behave exactly like the workflow creation form.
  • Fix invalid HTML markup; we were rendering nested buttons on multiple occasions.
  • Fix error state rendering for the Avatar Picker
  • Perfect Variable popover placement for multiline <ControlInput/>. Now that the editor occupies all the available space, the popover opens relative to the full box of the editor, so it's a bit further down than we want.

Screenshots

It's too late for so many screenshots. I advise reviewers to open the preview deployment next to the latest production deployment and test.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 3b6c09a
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/678ade6b7c38af0008ef3eed
😎 Deploy Preview https://deploy-preview-7536.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for dashboard-v2-novu-staging failed. Why did it fail? →

Name Link
🔨 Latest commit 3b6c09a
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/678ade6bcb677600089c1bea

Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants