fix(dashboard): wait for save when switching preview tab #7299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChmaraX
commented
Dec 13, 2024
Comment on lines
+17
to
+29
| const isNovuCloud = workflow.origin === WorkflowOriginEnum.NOVU_CLOUD && uiSchema; | ||
| const isExternal = workflow.origin === WorkflowOriginEnum.EXTERNAL; | ||
|
|
||
| const editorContent = ( | ||
| <> | ||
| {isNovuCloud && <EmailEditor uiSchema={uiSchema} />} | ||
| {isExternal && ( | ||
| <EmailTabsSection> | ||
| <CustomStepControls dataSchema={dataSchema} origin={workflow.origin} /> | ||
| </EmailTabsSection> | ||
| )} | ||
| </> | ||
| ); |
There was a problem hiding this comment.
Added more explicit conditions so its unified across steps
ChmaraX
commented
Dec 13, 2024
| @@ -12,8 +12,8 @@ const redirectKey = 'redirect'; | |||
| const primaryActionKey = 'primaryAction'; | |||
| const secondaryActionKey = 'secondaryAction'; | |||
|
|
|||
| export const InAppEditor = ({ uiSchema }: { uiSchema?: UiSchema }) => { | |||
| if (!uiSchema || uiSchema?.group !== UiSchemaGroupEnum.IN_APP) { | |||
There was a problem hiding this comment.
Not sure if its better to check for uiSchema in child or parent - moved to parent for consistency with email-editor
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
The preview components already had the logic to wait for preview data - the issue was that it was incorrectly mounted in
in-appdue to different tabs implementation compared toemail.tab-switch.mov
slow network:
3g-network.mov