Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): Nv 4866 Enable override custom controls and implement custom controls for Delay & Digest #7288

Open
wants to merge 15 commits into
base: next
Choose a base branch
from
Open

feat(dashboard): Nv 4866 Enable override custom controls and implement custom controls for Delay & Digest #7288

wants to merge 15 commits into from

Conversation

BiswaViraj
Copy link
Member

@BiswaViraj BiswaViraj commented Dec 12, 2024 •
edited
Loading

What changed? Why was the change needed?

Screenshots

Screen.Recording.2024-12-13.at.4.53.04.PM.mov
Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@linear Linear
Copy link

linear bot commented Dec 12, 2024

NV-4866 Display read only default control values for code-first workflows in the new Dashboard

@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 1024272
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/675c40ceb5ab8c000966cad8
😎 Deploy Preview https://deploy-preview-7288.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit 1024272
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/675c40ce0d90240008643e23
😎 Deploy Preview https://deploy-preview-7288.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BiswaViraj BiswaViraj changed the title feat(dashboard): Nv 4866 Enable override custom controls feat(dashboard): [NOT READY] Nv 4866 Enable override custom controls Dec 12, 2024
@BiswaViraj BiswaViraj force-pushed the nv-4866-display-read-only-default-control-values-for-code-first branch from f54771c to 6a4f22d Compare December 13, 2024 06:36
@BiswaViraj
feat(workflow-editor): add override toggle to custom step controls
889a7c6
@BiswaViraj
feat(workflow-editor): add lodash.isequal for data comparison and enh…
ca3c7c4 
…ance custom step controls
@BiswaViraj
feat(workflow-editor): enhance custom step controls with override fun…
d2514a6 
…ctionality and animations
@BiswaViraj
fix(dashboard): enhance readonly input styles for codemirror
ad79347
@BiswaViraj
fix(workflow-editor): correct variable name for default values compar…
21ba2c4 
…ison in configure step template form
@BiswaViraj
fix: grey ui on step change
0b9161a
@BiswaViraj
feat(workflow-editor): integrate SidebarContent into custom step cont…
a99c3ed 
…rols for improved layout
@BiswaViraj
fix(workflow-editor): wrap saveForm in an arrow function for consiste…
043f622 
…nt value change handling
@BiswaViraj
fix: step controls
8d5a0bc
@BiswaViraj
merge
799ec8e
@BiswaViraj
feat(workflow-editor): add custom control values for Delay and Digest…
d038160 
… step types
@BiswaViraj
feat(workflow-editor): enhance custom step controls with restore defa…
b78b6d5 
…ult functionality and documentation link
@BiswaViraj BiswaViraj force-pushed the nv-4866-display-read-only-default-control-values-for-code-first branch from 6a4f22d to b78b6d5 Compare December 13, 2024 10:55
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 13, 2024 •
edited
Loading

Open in Stackblitz

@novu/client

npm i https://pkg.pr.new/novuhq/novu/@novu/client@7288

@novu/framework

npm i https://pkg.pr.new/novuhq/novu/@novu/framework@7288

@novu/nest

npm i https://pkg.pr.new/novuhq/novu/@novu/nest@7288

@novu/headless

npm i https://pkg.pr.new/novuhq/novu/@novu/headless@7288

@novu/js

npm i https://pkg.pr.new/novuhq/novu/@novu/js@7288

@novu/nextjs

npm i https://pkg.pr.new/novuhq/novu/@novu/nextjs@7288

@novu/node

npm i https://pkg.pr.new/novuhq/novu/@novu/node@7288

@novu/notification-center

npm i https://pkg.pr.new/novuhq/novu/@novu/notification-center@7288

novu

npm i https://pkg.pr.new/novuhq/novu@7288

@novu/providers

npm i https://pkg.pr.new/novuhq/novu/@novu/providers@7288

@novu/react

npm i https://pkg.pr.new/novuhq/novu/@novu/react@7288

@novu/react-native

npm i https://pkg.pr.new/novuhq/novu/@novu/react-native@7288

@novu/shared

npm i https://pkg.pr.new/novuhq/novu/@novu/shared@7288

@novu/stateless

npm i https://pkg.pr.new/novuhq/novu/@novu/stateless@7288

commit: 1024272

@BiswaViraj
refactor(workflow-editor): simplify component structure by removing u…
53c5513 
…nnecessary wrappers around custom step controls
@BiswaViraj BiswaViraj changed the title feat(dashboard): [NOT READY] Nv 4866 Enable override custom controls feat(dashboard): Nv 4866 Enable override custom controls and implement custom controls for Delay & Digest Dec 13, 2024
@BiswaViraj BiswaViraj self-assigned this Dec 13, 2024
@BiswaViraj BiswaViraj marked this pull request as ready for review December 13, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SokratisVidros SokratisVidros Awaiting requested review from SokratisVidros

@LetItRock LetItRock Awaiting requested review from LetItRock

At least 1 approving review is required to merge this pull request.

Assignees

@BiswaViraj BiswaViraj

Labels
@novu/dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BiswaViraj