fix(api): parses some of the data as [OBJECT OBJECT] #7280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
commented
Dec 11, 2024
Comment on lines
+32
to
+33
| const INVALID_VARIABLE_PLACEHOLDER = '<INVALID_VARIABLE_PLACEHOLDER>'; | ||
| const PREVIEW_ERROR_MESSAGE_PLACEHOLDER = `[[Invalid Variable: ${INVALID_VARIABLE_PLACEHOLDER}]]`; |
There was a problem hiding this comment.
I am open to error message suggestions :)
djabarovgeorge
commented
Dec 11, 2024
There was a problem hiding this comment.
Now, the liquid parser is aware of the Novu-supported variables, and it passes it to its client.
djabarovgeorge
commented
Dec 11, 2024
Comment on lines
+66
to
+68
| if (keys.length === 1) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
this solves cases if user provides the following control value:
{{subscriber}} {{subscriber.firstName}}
in such case API would trow 500 TypeError: Cannot create property 'firstName' on string '{{subscriber}}'
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
changed the title
djabarovgeorge
changed the title
djabarovgeorge
commented
Dec 13, 2024
| * we need to remove the '{{' and '}}' from the invalid variable name | ||
| * so that framework can parse it without errors | ||
| */ | ||
| const invalidVariableExpression = invalidVariable.name.replace('{{', '').replace('}}', ''); |
There was a problem hiding this comment.
self note: need to replace all (the same) invalid outputs at once here.
Suggested change
| const invalidVariableExpression = invalidVariable.name.replace('{{', '').replace('}}', ''); | |
| const invalidVariableExpression = invalidVariable.name.replaceAll('{{', '').replace('}}', ''); |
|
this progress was cherry-picked to #7303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
this PR solves the issue that was raised, but there are still issues with the preview we will need to solve. i was not able to solve anything that was happening in PrepareAndValidateContentUsecase, because changing one issue caused another.
Note: This PR addresses all potential Liquid JS runtime errors during the preview process, based on the current Novu implementation, which supports basic Liquid JS output with filters.
Here is a summary i was able to do while working on this ticket:
{{subscriber}}
{{subscriber}} {{subscriber.firstName}}
TypeError: Cannot create property 'firstName' on string '{{subscriber}}'.{{subscriber asd}}
{{payload..name | upcase}}
BridgeRequestError: Workflow with id: asd-opyf has invalid controls syntax in step with id: in-app-step. Please correct step control syntax.(Liquid.js fails to parse invalid template output.){{payload | upcase}}
[OBJECT OBJECT].payloadvariable. In the pipeline,payload: {}is passed, and Liquid.js outputs{}.toString().- SOLVED: Now replaced with text ([[Invalid Variable: ...]]).
{{payload.name ca}}
{{payload.name ca | upcase}}
payload.namevariable. Since the variable is not provided, it renders nothing.{{payload}} or {{payload adasds}}
Example of before
After
Expand for optional sections
Related enterprise PR
Special notes for your reviewer