Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(novu): Respect .env values for API URL and SECRET_KEY #7279

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

SokratisVidros
Copy link
Contributor

What changed? Why was the change needed?

This is just a DX improvement for npx novu sync command. If these env vars are set, novu sync command should use them instead of requiring the corresponding CLI Argumentthe

If these env vars are set, novu sync command should use them instead of requiring the corresponding CLI Argumentthe
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 6b99db0
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/6759c81435f3070008b16304
😎 Deploy Preview https://deploy-preview-7279.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit 6b99db0
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/6759c816a0ccc400081288bb
😎 Deploy Preview https://deploy-preview-7279.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@SokratisVidros SokratisVidros merged commit 1ba3446 into next Dec 12, 2024
32 of 33 checks passed
@SokratisVidros SokratisVidros deleted the teach_novu_cli_to_respect_dotenv branch December 12, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants