fix(dashboard): Apply UI fixes to email and in-app editor #7278
+19
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
commented
Dec 11, 2024
| @@ -29,7 +29,7 @@ export const InAppPreview = (props: InAppPreviewProps) => { | |||
| return ( | |||
| <div | |||
| className={cn( | |||
| 'border-foreground-200 to-background/90 pointer-events-none relative mx-auto flex h-full w-full flex-col gap-4 rounded-xl px-2 py-3 shadow-sm', | |||
| 'border-foreground-200 to-background/90 pointer-events-none relative mx-auto flex h-full w-full flex-col gap-4 rounded-xl px-4 py-3 shadow-sm', | |||
There was a problem hiding this comment.
Fix alignment issues between the body and the preview header. Padding and margin should always be on the layout level, not on each component of the preview.
| <EmailTabsEditSection> | ||
| <CustomStepControls dataSchema={dataSchema} origin={workflow.origin} /> | ||
| </EmailTabsEditSection> | ||
| {workflow.origin === WorkflowOriginEnum.NOVU_CLOUD && ( |
There was a problem hiding this comment.
Show sections based on workflow type avoiding redundant empty divs or the dangling Email Acme header
LetItRock
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
See preview deployment