feat(api): plain cards fetch user organizations #7268
Conversation
jainpawan21
had a problem deploying
to
Linting
GitHub Actions
Failure
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -0,0 +1,45 @@ | |||
| import { ApiProperty } from '@nestjs/swagger'; | |||
|
|
|||
| export class PlainCutomer { | |||
There was a problem hiding this comment.
| export class PlainCutomer { | |
| export class PlainCustomer { |
| externalId?: string; | ||
| } | ||
|
|
||
| export class PlainCardRequestDto { |
There was a problem hiding this comment.
Are there any types available to export from their SDK?
| import { BaseCommand } from '@novu/application-generic'; | ||
| import { IsArray, IsDefined, IsOptional, IsString } from 'class-validator'; | ||
|
|
||
| export class PlainCutomer { |
There was a problem hiding this comment.
There seem to be some duplication in the DTO's I would suggest simplifying this a bit, or reusing if they are identical, just for simplifying our maintenance.
There was a problem hiding this comment.
Should we consider renaming this usecases to: get-plain-cards.usecase.ts ? And then just have multiple functions for each card inside?
| }, | ||
| ], | ||
| }; | ||
| async getUserOrganizations(@Body() body: PlainCardRequestDto) { |
There was a problem hiding this comment.
How authorization happening here? We need to verify the HMAC using their signing key and enforce it.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer