feat(web): Novu Dashboard fix- After clearing the search a provider input selected tab list should be visible not to show list from begining #6386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arunshaik2001
changed the title
Arunshaik2001
changed the title
Arunshaik2001
changed the title
BiswaViraj
approved these changes
Oct 20, 2024
jainpawan21
pushed a commit
that referenced
this pull request
Oct 20, 2024
…nput selected tab list should be visible not to show list from begining (#6386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
fixes #6385
Clearing the provider input text make the list render from beginning of the list irrespective of selected tab.
calling scrollToElement on selected tab after getting empty string.
Screenshots
novu-sidebar-fix.mp4
Expand for optional sections
Special notes for your reviewer
I've added timeout of 1000ms so that providers list is first rendered and then scrolled to selected tab.