Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(framework): add NestJS guide and icons #709

Merged

Conversation

rifont
Copy link
Collaborator

@rifont rifont commented Oct 9, 2024

What?

  • Add NestJS Framework handler documentations
  • Add icons for all Novu Framework quickstart guides in the overview page

Closes novuhq/novu#6552

Screenshots

Preview deployment
https://novu-nv-4304-docs-feedback-add-informations-about-how-to-us.mintlify.app/quickstart/nestjs

Copy link

linear bot commented Oct 9, 2024

@rifont rifont requested a review from SokratisVidros October 9, 2024 17:40
"quickstart/express",
"quickstart/remix",
"quickstart/nestjs",
"quickstart/svelte",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reordering here based on perceived frequency of usage, from most to least used.

}, {
payloadSchema: z.object({
userName: z.string().default('John Doe'),
}),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing some whitespace issues.

@@ -9,6 +9,7 @@ import TestStep from "/snippets/quickstart/test.mdx";
import PackagesStep from "/snippets/quickstart/packages.mdx";
import SecretStep from "/snippets/quickstart/secret.mdx";
import WorkflowCode from "/snippets/quickstart/workflow.mdx";
import NextStepsStep from "/snippets/quickstart/next-steps.mdx";
Copy link
Collaborator Author

@rifont rifont Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import was missing and previously resulted in the "Next steps" section not being rendered at all for the Remix guide.

Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@rifont rifont merged commit c680b46 into main Oct 10, 2024
1 check passed
@rifont rifont deleted the nv-4304-docs-feedback-add-informations-about-how-to-use-novu-with branch October 10, 2024 09:41
import { NovuModule } from '@novu/framework/nest';
import { testWorkflow } from './novu/workflows';

@Module({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix identation, we use 2 spaces.

}),
}, {
payloadSchema: z.object({
userName: z.string().default('John Doe'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📚 Docs Feedback: Add informations about how to use Novu with NestJs
3 participants