feat(file-id): add get_file_id_no_follow() along with low and high-res variants.
#716
+90
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall LGTM but I'd like to see CI results, could you fix formatting? |
…res variants. That way it's possible to get the file-id of symlinks, and fully replicate the capabilities of the standard library, but without requiring nightly.
|
Thanks a lot, and I am very sorry for the formatting issue. I did expect my IDE to auto-format it, but apparently that's disabled by default so nothing was formatted. This I now fixed, and I hope CI will go through without a hitch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way it's possible to get the file-id of symlinks, and fully replicate the capabilities of the standard library, but without requiring nightly.
Please not that the majority of the PR was created by Copilot, but I reviewed it thoroughly and cleaned it up just a little.
Related to gitbutlerapp/gitbutler#10528