-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: Fix server hangs under some circumstance #674
base: main
Are you sure you want to change the base?
Conversation
6d0e731
to
ab92967
Compare
Moving a folder to the Recycle Bin or deleting a folder triggers
Interestingly, when the folder is deleted instead of moved to the Recycle Bin, the second Changes in this PR:
|
Hi, thank you so much for creating such a high-quality Rust library.
We encountered a tricky issue while using this library in the development of Zed (https://github.com/zed-industries/zed). After testing, we identified the issue as a bug in
notify
. This PR provides a test case,test_windows_trash_dir()
, which reproduces the bug.The bug can be reproduced as follows: in a project directory
/path/to/project
, there is a subfolder/path/to/project/child
. If we monitor changes in the child folder, then move the child folder to the trash (deleting the folder directly does not trigger the bug), and monitor the project directory, the server gets stuck at theWaitForSingleObjectEx
command.This issue seems to be related to thebAlertable
flag inWaitForSingleObjectEx
, but we are still unclear why settingbAlertable
toTRUE
causes this bug.