Fix Dockerfile permissions and add .dockerignore #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
fix_dockerfile_permissions
branch
from
8c38523 to
47c05e2
Compare
thaJeztah
commented
Oct 16, 2019
| @@ -0,0 +1,16 @@ | |||
| .cover | |||
| .dockerignore | |||
There was a problem hiding this comment.
Removed .git, as it's used by the server.Dockerfile to generate the version output. We could consider doing that outside of the container, but that may complicate building the Dockerfile (e.g. through docker hub autobuild)
thaJeztah
force-pushed
the
fix_dockerfile_permissions
branch
3 times, most recently
from
fbbd022 to
100b8b8
Compare
thaJeztah
force-pushed
the
fix_dockerfile_permissions
branch
from
100b8b8 to
55d2bff
Compare
Before this, running the circle-ci integration tests showed some failures: ``` pkcs11 import was not found anywhere without a build tag, yay find: './cmd/notary/tuf/gun': Permission denied find: './cmd/notary/tuf/gun': Permission denied find: './cmd/notary/tuf/gun': Permission denied find: './cmd/notary/tuf/gun': Permission denied find: './cmd/notary/tuf/gun': Permission denied find: './cmd/notary/tuf/gun': Permission denied lstat cmd/notary/tuf/gun: permission denied lstat cmd/notary/tuf/gun: permission denied ``` With this patch applied, the tests run without issues. This patch modifies the circle-ci script accordingly, and makes a small convenience change when running the tests locally; adding `-it` allows for the containers to be terminated (CTRL-C), which was not possible previously. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
fix_dockerfile_permissions
branch
from
55d2bff to
1e3ec89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile: fix permissions, use "notary" as default user
Before this, running the circle-ci integration tests showed some failures:
With this patch applied, the tests run without issues.
This patch modifies the circle-ci script accordingly, and makes a small
convenience change when running the tests locally; adding
-itallowsfor the containers to be terminated (CTRL-C), which was not possible
previously.
Add .dockerignore to ignore build and test artefacts
Ignore files that are unlikely needed in the dockerfile