Add http.Request to doAuth to use with challenge.SetHeaders #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
You need to bump the vendoring here as we use vendoring in this repo, regardless of whether you use the vendoring. |
|
Might need some help with that, running |
|
vndr only works correctly if the package is located in the GOPATH, a caveat not mentioned on the README. |
|
Oh yes, sorry, Looks like the new version of |
added 3 commits
May 14, 2019 17:51
Newer challenge.SetHeaders takes two parameters, r *http.Request and w http.ResponseWriter. See commit distribution/distribution@f730f3a Signed-off-by: Robert-André Mauchin <[email protected]>
Signed-off-by: Robert-André Mauchin <[email protected]>
Signed-off-by: Robert-André Mauchin <[email protected]>
eclipseo
force-pushed
the
fix_for_newer_auth
branch
from
6164a1b to
32289a1
Compare
justincormack
approved these changes
May 14, 2019
|
cc @cyli @endophage |
endophage
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer challenge.SetHeaders takes two parameters, r *http.Request and
w http.ResponseWriter.
See commit distribution/distribution@f730f3a
Signed-off-by: Robert-André Mauchin [email protected]
You will need to bump github.com/docker/distribution vendoring if you wanna use this. In Fedora we unbundle all the dependencies, so we need to work with the latest version.