Refactored to support both input and output devices #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for input devices turned out to just be a change from passing
DataFlow.RendertoDataFlow.Captureto theMMDeviceEnumerator. I pretty much just renamed theOutputDeviceclass toAudioDeviceand added aDataFlowproperty you can pass to the constructor so you can create a list of either output or input devices depending on whichDataFlowyou pass in. The input actions are mostly copied from the output actions with some changes to adapt to the new universal class.I also needed to add an extra indicator to the icon to specify if that button was an output device or input device. Since I was doing that, it felt like the default selected device checkmark worked better as small image instead of a full icon size.
Was my first time working with a LoupeDeck plugin so hopefully it all looks alright.