Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set status-style when disabling the nord statusline #64

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

0phoff
Copy link

@0phoff 0phoff commented Nov 19, 2021

This commits fixes the code to not set the status-style option when disabling the nord-tmux status-bar.

Usually, when disabling the status-bar, it means a user wants to customize it to his/her liking.
For some reason, overriding this status-style option before creating your own bar does not seem to work.
The only way I got things working was to explicitly remove that option from your code.

By setting this option in the nord-status-content.conf and nord-status-content-no-patched-font.conf files, we ensure it gets only set when a user actually uses the provided status-bars.

@arcticicestudio
Copy link
Contributor

Hi @0phoff 👋, thanks for your contribution 👍
I'll try to review and test the changes within the next weeks.

@arcticicestudio
Copy link
Contributor

@0phoff Thanks for your patience, it's been busy times again.
Can you please provide a MCVE that shows how the status-style option prevents users from defining their own status bar content? I tried to reproduce it by setting the @nord_tmux_show_status_content variable to 0 and defining custom content for the right bar (set -g status-right "..."), but it works fine even the custom content is defined after loading the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants