[5.14] Bumping version from 5.14.12 to 5.14.15 #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[5.14] Bumping version from 5.14.12 to 5.14.15 Signed-off-by: liranmauda <[email protected]>
nimrod-becker
approved these changes
Jan 30, 2025
Without setuptools, running operator-courier fails with:
```
Traceback (most recent call last):
File "/Users/zregvart/work/croz/noobaa/noobaa-operator/build/_output/venv/bin/operator-courier", line 5, in <module>
from operatorcourier.cli import main
File "/Users/zregvart/work/croz/noobaa/noobaa-operator/build/_output/venv/lib/python3.13/site-packages/operatorcourier/cli.py", line 2, in <module>
import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'
make: *** [gen-olm] Error 1
```
Signed-off-by: Zoran Regvart <[email protected]>
(cherry picked from commit 06528c3)
- Using `golangci-lint` for lint in the Makefile target - Adding `.golangci.yml` as a configuration file - Fixing some lint errors Signed-off-by: liranmauda <[email protected]> (cherry picked from commit 496b2dd) Signed-off-by: liranmauda <[email protected]> (cherry picked from commit 4c639de)
Removing golangci-lint-action in favor or make lint Signed-off-by: liranmauda <[email protected]> (cherry picked from commit 88564d2) Signed-off-by: liranmauda <[email protected]> (cherry picked from commit b9ddc66)
Fixing the CLI decision error handling to avoid lint errors Signed-off-by: liranmauda <[email protected]> (cherry picked from commit 10d81d1) Signed-off-by: liranmauda <[email protected]> (cherry picked from commit 84fd086)
Removing lint call on `make test` Signed-off-by: liranmauda <[email protected]> (cherry picked from commit 026a423)
Update GH actions Signed-off-by: liranmauda <[email protected]> (cherry picked from commit 75eb746)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
[5.14] Bumping version from 5.14.12 to 5.14.15