NC | NSFS | CLI | Separate Bucket and Account List Functions #8747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
list_config_files
tolist_bucket_config_files
andlist_account_config_files
.filter_bucket
andlist_bucket_config_files
under the buckets part, and movelist_connections
to the notifications part.filter_list_item
as we use the functionsfilter_account
andfilter_bucket
directly.test_nc_nsfs_bucket_cli.test.js
(after adding them I saw that we had them in the filetest_nc_nsfs_cli.js
but decided to keep them).Issues:
Testing Instructions:
Automatic tests
Please run:
sudo npx jest test_nc_nsfs_account_cli.test.js
sudo npx jest test_nc_nsfs_bucket_cli.test.js
(here 2 cases were added)sudo NC_CORETEST=true node node_modules/mocha/bin/mocha src/test/unit_tests/test_nc_nsfs_cli.js