bucket notifications - adapt to xml conversion

[alphaprinz]

Explain the changes

1. Adapt get-bucket-notif reply to be converted to xml.

Issues: Fixed #xxx / Gap #xxx

1. https://issues.redhat.com/browse/DFBUGS-1507 (partly)

Testing Instructions:

• Doc added/updated
• Tests added

[guymguym]

just a suggestion of how we typically build these xml results from js objects with a more functional style.

we use _.map(arr, fn) just because it won't fail if the array is undefined, while for arr.map(fn) will fail, but if you prefer you can also just do (arr || []).map(fn).

const topics = await req.object_sdk.get_bucket_notification({
    bucket_name: req.params.bucket,
});

return {
    NotificationConfiguration: _.map(topics, t => ({
        TopicConfiguration: [
            {
                Id: t.id,
                Topic: t.topic,
            },
            _.map(t.event, e => ({
                Event: e
            }))
        ]
    }))
};

[guymguym]

no need to wrap the map with [] because it always returns an array

Suggested change

	NotificationConfiguration: [_.map(result, t => ({
	NotificationConfiguration: _.map(result, t => ({

[guymguym]

approved, just one minor comment