Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding upgrade script to bucket CORS - new bucket default will be the same as in 5.18 #8729

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

jackyalbo
Copy link
Contributor

Explain the changes

  1. A new bucket will be added by default the config.js's S3_CORS_* constants
  2. A new CORS upgrade script - the default config will be added to all old buckets

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@jackyalbo jackyalbo force-pushed the jacky-cors-fixes branch 2 times, most recently from 7d13678 to cea460b Compare January 30, 2025 07:27
@jackyalbo jackyalbo requested a review from liranmauda January 30, 2025 07:47
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: jackyalbo <[email protected]>
@jackyalbo jackyalbo merged commit aa6f37c into noobaa:master Jan 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants