Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to break semaphore circular dependency #8728

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

jackyalbo
Copy link
Contributor

@jackyalbo jackyalbo commented Jan 28, 2025

Explain the changes

  1. We found a circular dependency in our code between: promise -> semaphore -> wait_queue -> promise
  2. We want to handle in 2 ways:
    2.1 We wont import the whole promise module into wait_queue - we will take defer out and create new class to be imported
    2.2 As semaphore was create as empty object due to this issue - we won't import dircectly semaphore object in our code but will import its parent file which will allow the object to be loaded in case of future circular dependencies involving this module.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed https://issues.redhat.com/browse/DFBUGS-1471

Testing Instructions:

  1. Ensure you don't see any "Semaphore is not a constructor" in our logs.
  • Doc added/updated
  • Tests added

@jackyalbo jackyalbo requested a review from dannyzaken January 28, 2025 08:32
@jackyalbo jackyalbo force-pushed the jacky-fix5 branch 2 times, most recently from 44f2563 to b198c93 Compare January 29, 2025 13:39
@jackyalbo jackyalbo merged commit 883e1b1 into noobaa:master Jan 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants