NC | NSFS | Add Concurrency Tests #8394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirady
force-pushed
the
nsfs-nc-versioning-concurrency-tests
branch
from
725ca55 to
9cc8b90
Compare
nadavMiz
reviewed
Sep 23, 2024
nadavMiz
reviewed
Sep 23, 2024
romayalon
reviewed
Sep 24, 2024
src/test/unit_tests/jest_tests/test_versioning_concurrency.test.js
Outdated
Show resolved
Hide resolved
shirady
force-pushed
the
nsfs-nc-versioning-concurrency-tests
branch
2 times, most recently
from
2c262f6 to
a534e27
Compare
romayalon
approved these changes
Sep 25, 2024
1. Add 2 cases to our concurrency tests: - Key with 5 versions, concurrent delete of 3 latest versions (no veID) -> 3 delete markers - Start with 1 version, 10 Puts + 10 Reads (latest) concurrent nothing fails -> 11 version IDs 2. Refactor the file test_versioning_concurrency for reuse: move tmp_fs_path and nsfs as global variables, add the helper function _upload_versions from existing code to avoid code duplication. Signed-off-by: shirady <[email protected]>
shirady
force-pushed
the
nsfs-nc-versioning-concurrency-tests
branch
from
40d2c6a to
10d6fc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
test_versioning_concurrencyfor reuse: movetmp_fs_pathandnsfsas global variables, add the helper function_upload_versionsfrom existing code to avoid code duplication.Issues: Fixed #xxx / Gap #xxx
concurrent put object and head object latest versionnotice that I increased the retries for 10 iterations (I could use the default with 5 iterations).Testing Instructions:
sudo npx jest test_versioning_concurrency.test.js