Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations: Improve Chinese translation #3467

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Conversation

Junior2Ran
Copy link
Contributor

@Junior2Ran Junior2Ran commented Feb 6, 2025

Describe your changes

Fix spelling mistake in Chinese translation.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

Steps to Reproduce

Notes

@cebtenzzre
Copy link
Member

@Junior2Ran Our Simplified Chinese translation does not have an active maintainer—there are 70 strings not filled in currently. Would you possibly be able to provide translations for those strings or review an AI-generated translation of them?

@Junior2Ran
Copy link
Contributor Author

Junior2Ran commented Feb 12, 2025

@Junior2Ran Our Simplified Chinese translation does not have an active maintainer—there are 70 strings not filled in currently. Would you possibly be able to provide translations for those strings or review an AI-generated translation of them?

@cebtenzzre Sure, I'm glad to help. What can I do?

Since the spelling mistake in this PR is so obvious at homepage, I'm not really famaliar with this repo actually. So maybe you can tell me what part in which files need to be filled, and whether there is other config file should be edited.

@cebtenzzre
Copy link
Member

Sure, I'm glad to help. What can I do?

I've cleaned up the zh_CN translation file on the main branch to simplify things. The process for updating the translation is as follows:

  1. Install Qt Linguist, which is part of Qt Tools.
  • The simplest way to get this is to download the Qt Installer from here. You need to have a Qt account to do this, which you can create for free.
  • To install Qt Tools, uncheck everything that is selected by default. All you need is the latest stable Qt for your platform. On Windows, this would be Qt > Qt 6.8.2 > MSVC 2022 64-bit. Select that and finish the installation.
  1. Check out the latest GPT4All source code. You may use git if you prefer, but this can be as simple as Code > Download ZIP on the repo's homepage. You can extract that to any convenient location.
  2. Open Qt Linguist. Go to File > Open. Navigate to the checked out source code, then gpt4all-chat/translations, and select gpt4all_zh_CN.ts.
  3. Review the translations.
  • Most importantly, gray question marks indicate string with no translation. Yellow question marks indicate translations that exist but have not been marked as done. Red exclamation marks indicate translations with warnings, and yellow checkmarks indicate translations with warnings that have been marked as done. If you ever see a gray checkmark, you can ignore that string; it is an old one kept only for reference purposes. But we purge those occasionally, which I just did for this file.
  • The goal is to fill in and fix the translations if needed, and then mark them as done using the green checkmark in the toolbar, to get as many checkmarks (especially green ones) as possible. This indicates a complete translation file.
  1. To test your translation, you can click File > Release As and save the .qm file somewhere convenient. You can then copy this file into the GPT4All data folder. On Windows this defaults to %LOCALAPPDATA%\nomic.ai\GPT4All. This will allow you to preview the translation in GPT4All after starting it (close it first if it is already running).
  2. When you have finished, you can use File > Save and then send us the completed .ts file (the one you opened in the source code directory). You can use git to push it to your fork if you prefer, otherwise just upload it to this folder via Add file > Upload files.
  3. The best way to stay in the loop is to join the GPT4All Discord and use the #translations channel. This is the primary place where we communicate with translators.

Thanks!

@Junior2Ran
Copy link
Contributor Author

OK, that's very clear. QT is installing. I am about to do it in spare time.

@Junior2Ran
Copy link
Contributor Author

@cebtenzzre @manyoso Those unfinished translation has been done. Please review again, thanks.

@cebtenzzre
Copy link
Member

Those unfinished translation has been done. Please review again, thanks.

Thank you!

For legal reasons, we need all commits from outside contributors to include a Signed-off-by line, to confirm that you are submitting them under our MIT license and copyright. Unfortunately, it looks like it was missed in one of your commits.

There are some instructions on how to fix that here, but if that's too complicated you could just make a new PR. The change itself looks great.

@Junior2Ran Junior2Ran force-pushed the main branch 2 times, most recently from 0366ca9 to 5a020d6 Compare February 20, 2025 03:40
@Junior2Ran
Copy link
Contributor Author

Junior2Ran commented Feb 20, 2025

@cebtenzzre Commits with Signed-off issue have been fixed.

Signed-off-by: Jared Van Bortel <[email protected]>
@cebtenzzre cebtenzzre merged commit 0c28ee7 into nomic-ai:main Feb 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants