Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gevent required version changed #106

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Korridzy
Copy link

@Korridzy Korridzy commented Feb 25, 2021

See #105.
pip install gevent -U worked fine. So I changed requirement

@noisyboiler
Copy link
Owner

thanks @Korridzy. will look at this asap.

@noisyboiler
Copy link
Owner

appreciated @Korridzy
looks like a build issue not at all to do with your changes

ERROR: Could not find a version that satisfies the requirement pytest-capturelog==0.7 (from wampy[dev])
ERROR: No matching distribution found for pytest-capturelog==0.7
The command "pip3 install --editable .[dev]" failed and exited with 1 during .

@Korridzy
Copy link
Author

Korridzy commented Mar 1, 2021

#107 #108 fixtures added

@Korridzy
Copy link
Author

Korridzy commented Mar 1, 2021

appreciated @Korridzy
looks like a build issue not at all to do with your changes

ERROR: Could not find a version that satisfies the requirement pytest-capturelog==0.7 (from wampy[dev])
ERROR: No matching distribution found for pytest-capturelog==0.7
The command "pip3 install --editable .[dev]" failed and exited with 1 during .

ok, I'll take a look now

@noisyboiler
Copy link
Owner

@Korridzy try bumping the req to pytest-capturelog-0.1.0

@Korridzy
Copy link
Author

Korridzy commented Mar 1, 2021

@Korridzy try bumping the req to pytest-capturelog-0.1.0

The history page for pytest-capturelog looks a bit strange. It says the only release was 0.1.0 on 27 feb 2021...

@noisyboiler
Copy link
Owner

@Korridzy will help with the build tomorrow. sorry this has been such hard work for you.

@noisyboiler
Copy link
Owner

Hi @Korridzy
I'd like to merge this and get your footprint on the wampy project.
Thank you for exposing the bug. It's been fixed in a parallel PR but please do update your fork so I can merge this in.
Keep up the good work and email me with your thoughts on this project!
Simon

@Korridzy
Copy link
Author

Hi @noisyboiler
Sorry for delay. Now I've merged this branch with your master and also made a couple of changes in it:

  • More smooth importing solution for wampy.roles
  • gitignore update for Pycharm users

Travis tests failed for reason unrelated to my updates. Temporary processing power lack or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants