Add contribute link to navbar #7274
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- apps/site/navigation.json: Language not supported
- packages/i18n/locales/en.json: Language not supported
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -20,6 +20,11 @@ | |||
| "link": "https://nodejs.org/docs/latest/api/", | |||
| "label": "components.containers.navBar.links.docs" | |||
| }, | |||
| "contribute": { | |||
There was a problem hiding this comment.
OOC -- what is the point of a contribute page within the website if we simply redirect here? Should we then simply delete the page and make the link on the sidebar also redirect here? I'm fine with that TBH and possibly is the best thing to be done here, can you do that?
There was a problem hiding this comment.
I can certainly do that, but as we've learned recently, this is a CONTENT VS CODE decision.
I've audited the content on https://nodejs.org/en/about/get-involved/contribute, comparing it to https://github.com/nodejs/node/blob/main/CONTRIBUTING.md. I want to make sure we are not net-losing content that may not be present within https://github.com/nodejs/node/blob/main/CONTRIBUTING.md
| website section | comparative location on main repo | plan |
|---|---|---|
| asking for general help | linked on the doc | ✅ already handled |
| reportng an issue, general | linked on the doc | ✅ already handled |
| reporting an issue specific to the website | nothing | do nothing, expect to triage and move issues? |
| reporting and issue, website status link | nothing | non-blocking in my opinion, already on the README of nodejs.org. Add to org-level README or nodejs/node README as other work |
| Code contributions | linked on the doc | ✅ already handled |
| node todo link | differing content | ✅ already handled |
| becoming a collaborator | linked to, found within GOVERNANCE.md | ✅ already handled |
There was a problem hiding this comment.
Technically speaking we wouldn't be authoring content; But removing it, which IMO we've done plenty of times before 👀
|
todo: we also need a redirect |
Description
Does the simplest thing we can to improve visibility of contribution, while avoiding some of the problems we encountered with the version support docs.
As @joyeecheung accurately points out, directly linking to this content is the best way to keep it up to date.
Open to iteration, but I wanted to advance the conversation with a concrete implementation.
Validation
See the preview build
Related Issues
closes #7237
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.