Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AvatarGroup): update overflow #7273

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

AugustinMauroy
Copy link
Member

Description

@ovflowd suggested on slack to wrap instead of overflow which I thought was a good idea so here's the pr!

Related Issues

No related issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • apps/site/components/Common/AvatarGroup/Avatar/index.module.css: Language not supported
  • apps/site/components/Common/AvatarGroup/index.module.css: Language not supported
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 23, 2024 2:22pm

@RedYetiDev RedYetiDev changed the title feat(AvatarGroupe): update overflow feat(AvatarGroup): update overflow Nov 21, 2024
@canerakdas canerakdas added the github_actions:pull-request Trigger Pull Request Checks label Nov 21, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 21, 2024
Copy link

github-actions bot commented Nov 21, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 77 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.483s ⏱️

@canerakdas
Copy link
Member

Looks great! 🤩 Only thing I noticed is that it seems like it's overflowing outside its container on the blog listing page and the blog detail page

image image

@AugustinMauroy
Copy link
Member Author

Noted I'll take time for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants