Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated, scheduled crowdin sync #7272

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

bmuenzenmeyer
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer commented Nov 21, 2024

Description

Introduces an automated way to initiate crowdin syncs.
In talking with the crowdin team, this seemed to be the logical next step.

Note that this does not replace our existing workflow, which:

  • tells people when they are translating something manually
  • formats incoming PRs to adhere to our standards

Validation

  • Post-merge, we will see what it does - i will run a workflow_dispatch
  • We can also turn it on with dry-run and a workflow trigger. will add that after typing this up
  • Update TRANSLATION guide to reflect this new method

Related Issues

#7121

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 24, 2024 0:58am

@bmuenzenmeyer

This comment was marked as resolved.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 suggestion.

.github/workflows/translations-sync.yml Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 21, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
Copy link

github-actions bot commented Nov 21, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.468s ⏱️

.github/workflows/translations-sync.yml Outdated Show resolved Hide resolved
@bmuenzenmeyer
Copy link
Collaborator Author

@nodejs/web-infra one last pass on this would be appreciated

TRANSLATION.md Outdated Show resolved Hide resolved
Co-authored-by: Michael Esteban <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants