Skip to content

Update remaining logo #7227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 16, 2024
Merged

Update remaining logo #7227

merged 3 commits into from
Nov 16, 2024

Conversation

AugustinMauroy
Copy link
Member

Description

update "old" logo.

Related Issues

nodejs/admin#934

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 13, 2024 8:42pm

@AugustinMauroy AugustinMauroy marked this pull request as ready for review November 13, 2024 17:38
@AugustinMauroy AugustinMauroy requested a review from a team as a code owner November 13, 2024 17:38
Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI apps/site/public/static/images/logo-hexagon-card.png is slightly smaller than it was previously (not in pixels, but the logo itself). That should be fine (IIUC), but it's worth noting just in case.

@AugustinMauroy
Copy link
Member Author

I'll try to do something

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.

Copy link
Contributor

github-actions bot commented Nov 16, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.5% (591/653) 76.06% (178/234) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
132 0 💤 0 ❌ 0 🔥 5.182s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Nov 16, 2024
Merged via the queue into main with commit 7cef2d5 Nov 16, 2024
15 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the udpate-ressources branch November 16, 2024 01:08
bmuenzenmeyer pushed a commit that referenced this pull request Nov 21, 2024
* Update logo-hexagon-card.png

* update favicon

* fix: logo-hexagon-card.png size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants