chore: simplified storybook/next config (#7280)

Co-authored-by: Augustin Mauroy <[email protected]>
nodejs · Nov 24, 2024 · c17fccb · c17fccb
1 parent d50d114
commit c17fccb
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 20 deletions.
diff --git a/apps/site/.storybook/main.ts b/apps/site/.storybook/main.ts
@@ -45,24 +45,14 @@ const config: StorybookConfig = {
     resolve: {
       ...config.resolve,
       alias: {
-        '@nodevu/core': false,
         'next-intl/navigation': join(mocksFolder, './next-intl.mjs'),
         '@/client-context': join(mocksFolder, './client-context.mjs'),
         '@': join(__dirname, '../'),
       },
     },
-    // We need to configure `node:` APIs as Externals to WebPack
-    // since essentially they're not supported on the browser
-    externals: {
-      'node:fs': 'commonjs fs',
-      'node:url': 'commonjs url',
-      'node:path': 'commonjs path',
-      'node:readline': 'commonjs readline',
-    },
     // Removes Pesky Critical Dependency Warnings due to `next/font`
     ignoreWarnings: [
       e =>
-        e.message.includes('Critical dep') ||
         e.message.includes('was not found in') ||
         e.message.includes('generated code contains'),
     ],

diff --git a/apps/site/next.config.mjs b/apps/site/next.config.mjs
@@ -7,11 +7,6 @@ import { redirects, rewrites } from './next.rewrites.mjs';
 
 /** @type {import('next').NextConfig} */
 const nextConfig = {
-  // Just to ensure that React is always on strict mode
-  reactStrictMode: true,
-  // We intentionally disable Next.js's built-in i18n support
-  // as we dom have our own i18n and internationalisation engine
-  i18n: null,
   // We don't use trailing slashes on URLs from the Node.js Website
   trailingSlash: false,
   // We don't want to redirect with trailing slashes
@@ -23,7 +18,8 @@ const nextConfig = {
   images: {
     // We disable image optimisation during static export builds
     unoptimized: ENABLE_STATIC_EXPORT,
-    // We add it to the remote pattern for the static images we use from GitHub
+    // We add it to the remote pattern for the static images we use from multiple sources
+    // to be marked as safe sources (these come from Markdown files)
     remotePatterns: [
       {
         protocol: 'https',

diff --git a/apps/site/turbo.json b/apps/site/turbo.json
@@ -16,7 +16,9 @@
         "NEXT_PUBLIC_BASE_PATH",
         "NEXT_PUBLIC_ORAMA_API_KEY",
         "NEXT_PUBLIC_ORAMA_ENDPOINT",
-        "NEXT_PUBLIC_DATA_URL"
+        "NEXT_PUBLIC_DATA_URL",
+        "TURBO_CACHE",
+        "TURBO_TELEMETRY_DISABLED"
       ]
     },
     "build": {
@@ -39,7 +41,9 @@
         "NEXT_PUBLIC_BASE_PATH",
         "NEXT_PUBLIC_ORAMA_API_KEY",
         "NEXT_PUBLIC_ORAMA_ENDPOINT",
-        "NEXT_PUBLIC_DATA_URL"
+        "NEXT_PUBLIC_DATA_URL",
+        "TURBO_CACHE",
+        "TURBO_TELEMETRY_DISABLED"
       ]
     },
     "start": {
@@ -55,7 +59,9 @@
         "NEXT_PUBLIC_BASE_PATH",
         "NEXT_PUBLIC_ORAMA_API_KEY",
         "NEXT_PUBLIC_ORAMA_ENDPOINT",
-        "NEXT_PUBLIC_DATA_URL"
+        "NEXT_PUBLIC_DATA_URL",
+        "TURBO_CACHE",
+        "TURBO_TELEMETRY_DISABLED"
       ]
     },
     "deploy": {
@@ -77,7 +83,9 @@
         "NEXT_PUBLIC_BASE_PATH",
         "NEXT_PUBLIC_ORAMA_API_KEY",
         "NEXT_PUBLIC_ORAMA_ENDPOINT",
-        "NEXT_PUBLIC_DATA_URL"
+        "NEXT_PUBLIC_DATA_URL",
+        "TURBO_CACHE",
+        "TURBO_TELEMETRY_DISABLED"
       ]
     },
     "lint:js": {