benchmark: fix incorrect base64 input in byteLength benchmark #60841
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmark for
Buffer.byteLengthwithencoding === 'base64'does notreturn a Base64-encoded string.
getInput()discards the encoded value andreturns the original UTF-8 string, causing the benchmark to run against
non-base64 input.
This patch ensures that when
encoding === 'base64', the function returns theactual Base64-encoded string.
This brings the benchmark in line with its expected behavior and makes the
results meaningful.
This fixes the benchmark issue reported in #60836.
Fixes #60836.