Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite: add support for custom functions #55985

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 24, 2024

This commit adds support to node:sqlite for defining custom functions that can be invoked from SQL.

Fixes: #54349

This commit adds support to node:sqlite for defining custom
functions that can be invoked from SQL.

Fixes: nodejs#54349
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 87.15084% with 23 lines in your changes missing coverage. Please review.

Project coverage is 87.99%. Comparing base (e92499c) to head (9909463).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 87.15% 10 Missing and 13 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #55985    +/-   ##
========================================
  Coverage   87.99%   87.99%            
========================================
  Files         653      653            
  Lines      188091   188270   +179     
  Branches    35941    35985    +44     
========================================
+ Hits       165516   165674   +158     
+ Misses      15751    15749     -2     
- Partials     6824     6847    +23     
Files with missing lines Coverage Δ
src/node_sqlite.h 70.00% <ø> (ø)
src/node_sqlite.cc 82.58% <87.15%> (+2.44%) ⬆️

... and 32 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlite: support sqlite3_create_function
2 participants