Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x backport] esm: mark import attributes and JSON module as stable #55961

Open
wants to merge 4 commits into
base: v20.x-staging
Choose a base branch
from
Open

[v20.x backport] esm: mark import attributes and JSON module as stable #55961

wants to merge 4 commits into from

Commits on Nov 22, 2024

  1. deps: V8: backport ae5a4db8ad86 

    Original commit message:

    [import-attributes] Deprecate 'assert' for removal in 12.6

    See https://groups.google.com/a/chromium.org/g/blink-dev/c/ZHvzLaJZRvo/m/FgNDBjrtBQAJ

    Bug: v8:10958
    Change-Id: I4d21c9f7aad1024b198b4a1cdfb4792a011da464
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5055681
    Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]>
    Auto-Submit: Shu-yu Guo <[email protected]>
    Commit-Queue: Shu-yu Guo <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#92044}

Refs: v8/v8@ae5a4db
Co-authored-by: Antoine du Hamel <[email protected]>
    @syg @aduh95
    syg and aduh95 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    9c6f94f View commit details
    Browse the repository at this point in the history

  2. deps: V8: cherry-pick 26fd1dfa9cd6 

    Original commit message:

    [import-attributes] Deprecate 'assert' for dynamic import as well

    Bug: v8:10958
    Change-Id: I7847bdb5d2c79f057f4e1df99f8f5889788f09cb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249778
    Commit-Queue: Shu-yu Guo <[email protected]>
    Reviewed-by: Leszek Swirski <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#92123}

Refs: v8/v8@26fd1df
    @syg @aduh95
    syg authored and aduh95 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    87a719a View commit details
    Browse the repository at this point in the history

  3. esm: mark import attributes and JSON module as stable 

    The two proposals reached stage 4 at the October 2024 meeting.

PR-URL: nodejs#55333
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
    @nicolo-ribaudo @aduh95
    nicolo-ribaudo authored and aduh95 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    acbfd16 View commit details
    Browse the repository at this point in the history

  4. doc: add history entries for JSON modules stabilization 

    PR-URL: nodejs#55855
Refs: nodejs#55333
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
    @aduh95
    aduh95 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    e44f6d8 View commit details
    Browse the repository at this point in the history