test_runner: refactor primordial-based Promise chains

[cjihrig]

This PR refactors two Promise chains in the test runner to use async/await style syntax instead. IMO this makes these two pieces of code significantly more readable (largely because of primordials), and will make some planned changes easier to implement.

test_runner: refactor build Promise in Suite()

This commit refactors the buildSuite Promise logic in the Suite
constructor to use an async function instead of creating an
awkward primordial-based Promise chain.

test_runner: refactor Promise chain in run()

This commit refactors the chain of functions in run() to use an
async function instead of creating an awkward primordial-based
Promise chain.

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (e92499c) to head (5f2f366).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #55958   +/-   ##
=======================================
  Coverage   87.99%   88.00%           
=======================================
  Files         653      653           
  Lines      188091   188090    -1     
  Branches    35941    35943    +2     
=======================================
+ Hits       165516   165523    +7     
+ Misses      15751    15734   -17     
- Partials     6824     6833    +9     

Files with missing lines	Coverage Δ
lib/internal/test_runner/runner.js	89.02% <100.00%> (+0.09%)	⬆️
lib/internal/test_runner/test.js	96.95% <100.00%> (-0.02%)	⬇️

... and 36 files with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63689/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63691/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/55958
✔  Done loading data for nodejs/node/pull/55958
----------------------------------- PR info ------------------------------------
Title      test_runner: refactor primordial-based Promise chains (#55958)
Author     Colin Ihrig <[email protected]> (@cjihrig)
Branch     cjihrig:promises -> nodejs:main
Labels     commit-queue-rebase, test_runner
Commits    2
 - test_runner: refactor build Promise in Suite()
 - test_runner: refactor Promise chain in run()
Committers 1
 - cjihrig <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/55958
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55958
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - test_runner: refactor build Promise in Suite()
   ⚠  - test_runner: refactor Promise chain in run()
   ℹ  This PR was created on Fri, 22 Nov 2024 21:02:13 GMT
   ✔  Approvals: 7
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/55958#pullrequestreview-2455645777
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/55958#pullrequestreview-2456378535
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/55958#pullrequestreview-2456381657
   ✔  - Pietro Marchini (@pmarchini): https://github.com/nodejs/node/pull/55958#pullrequestreview-2456382466
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/55958#pullrequestreview-2456411715
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55958#pullrequestreview-2456425980
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/55958#pullrequestreview-2456475030
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-11-25T00:15:13Z: https://ci.nodejs.org/job/node-test-pull-request/63691/
- Querying data for job/node-test-pull-request/63691/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/12002350325